perf: update alien signals to v0.5 & fixed performance regression since v2.1#122
Conversation
- Replace map-based effect queue with linked list implementation - Simplify queue management with head and tail pointers - Remove unused pauseStack field
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 927 930 +3
=========================================
+ Hits 927 930 +3
|
medz
changed the title
By setting a specific int value, the memory address lookup during runtime and the bit operations are reduced. |
|
Of course, this isn't mandatory; you can define ReactiveFlags constants in Solidart to represent these values. In my opinion, there's no difference between defining constants and specifying specific values and adding annotations. |
|
I really thought it was for performance reasons, although I also thought that saving them as constants was a good practice anyway, also to make the code more readable. BTW feel free to merge it yourself |
|
It has no impact on external APIs, it's just an internal optimization of Solidart, so my suggestion is to just release a fix version. E.g: |
|
@all-contributors please add @medz for code, bug, doc |
|
I've put up a pull request to add @medz! 🎉 |
2 participants
fixes #120